Allow cargo package --list even for things that don't package.
#8175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 156c651 has been approved by |
bors
added
S-waiting-on-bors
|
Thanks! |
|
☀️ Test successful - checks-azure |
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
May 6, 2020
Allow `cargo package --list` even for things that don't package. `cargo package --list` was changed in rust-lang#7905 to generate `Cargo.lock` earlier. If there is a problem, then it would fail where previously it would succeed. This changes it so that file generation is deferred until after `--list`. This also changes it so that the "dependencies must have a version" check is deferred until after `--list` as well. Closes rust-lang#8151
bors
added a commit
that referenced
this pull request
May 6, 2020
[beta] Allow `cargo package --list` even for things that don't package. Beta backport of #8175.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo package --listwas changed in #7905 to generateCargo.lockearlier. If there is a problem, then it would fail where previously it would succeed. This changes it so that file generation is deferred until after--list.This also changes it so that the "dependencies must have a version" check is deferred until after
--listas well.Closes #8151